refactor(support-math): Decouple support math from node APIs#1158
Merged
refactor(support-math): Decouple support math from node APIs#1158
Conversation
Add support-side keyspace and time-skew contracts so support.math no longer depends on node APIs. Also delegate the node-side compatibility types to the new support helpers and expand the supporting tests and Javadoc around the extracted behavior.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd5cf692fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/main/java/network/crypta/support/math/TimeDecayingRunningAverage.java
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyspaceMathandTimeSkewAlertCallbackas support-side keyspace and time-skew contractsDecayingKeyspaceAverageandTimeDecayingRunningAverageto use those support-side contracts instead ofnode.*APIsLocationandTimeSkewDetectorCallback, and add direct helper/parity coverage plus Javadoc for the new typesHow to test
./gradlew compileJava./gradlew test --tests "network.crypta.support.math.*"./gradlew test --tests "network.crypta.node.LocationTest"./gradlew testjavac -proc:none -Xdoclint:all -Werror -d /tmp/doclint-out-keyspace src/main/java/network/crypta/support/math/KeyspaceMath.javajavac -proc:none -Xdoclint:all -Werror -d /tmp/doclint-out-timeskew src/main/java/network/crypta/support/math/TimeSkewAlertCallback.java